Re: [Qemu-devel] [PATCH] trace: clean up trace-events files

[Daniel P. Berrange]

On Wed, Jan 25, 2017 at 02:14:26PM +0000, Stefan Hajnoczi wrote:
> There are a number of unused trace events that
> scripts/cleanup-trace-events.pl finds.  The "hw/vfio/pci-quirks.c"
> filename was typoed and "qapi/qapi-visit-core.c" was missing the qapi/
> directory prefix.
> 
> diff --git a/qapi/trace-events b/qapi/trace-events
> index 2c5d3bc..82a0b73 100644
> --- a/qapi/trace-events
> +++ b/qapi/trace-events
> @@ -1,4 +1,4 @@
> -# qapi-visit-core.c
> +# qapi/qapi-visit-core.c
>  visit_free(void *v) "v=%p"
>  visit_complete(void *v, void *opaque) "v=%p opaque=%p"
>  
> @@ -15,7 +15,6 @@ visit_end_alternate(void *v, void *obj) "v=%p obj=%p"
>  
>  visit_optional(void *v, const char *name, bool *present) "v=%p name=%s 
> present=%p"
>  
> -visit_type_enum(void *v, const char *name, int *obj) "v=%p name=%s obj=%p"

The actual bug is that the source file is mistakenly not calling this
trace point - we shouldn't delete it - we should call it from the
visit_type_enum() method


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|