[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] s390x/flic: fix compilation of kvm flic
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [Qemu-devel] [PATCH] s390x/flic: fix compilation of kvm flic |
|
Date: |
Wed, 25 Jan 2017 14:45:03 +0000 |
|
User-agent: |
Mutt/1.7.1 (2016-10-04) |
* Cornelia Huck (address@hidden) wrote:
> 2c21ee7 ("migration: extend VMStateInfo") missed a void -> int
> return conversion for kvm_flic_save().
>
> Fixes: 2c21ee7 ("migration: extend VMStateInfo")
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
> hw/intc/s390_flic_kvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/intc/s390_flic_kvm.c b/hw/intc/s390_flic_kvm.c
> index da8e4dfab6..e86a84e49a 100644
> --- a/hw/intc/s390_flic_kvm.c
> +++ b/hw/intc/s390_flic_kvm.c
> @@ -303,7 +303,7 @@ static int kvm_flic_save(QEMUFile *f, void *opaque,
> size_t size,
> * migration state */
> error_report("flic: couldn't allocate memory");
> qemu_put_be64(f, FLIC_FAILED);
> - return;
> + return 0;
> }
>
> count = __get_all_irqs(flic, &buf, len);
> --
> 2.11.0
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
as discussed, sort out an error return value later.
Dave
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK