Re: [Qemu-devel] [PULL 00/16] virtio, vhost, pci: fixes, features

[Marcel Apfelbaum]

On 01/25/2017 06:36 PM, Peter Maydell wrote:
> On 24 January 2017 at 22:36, Michael S. Tsirkin <address@hidden> wrote:
> > The following changes since commit a9e404600a9bd1e6a26431fc89e5069092e67f14:
> >
> >   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20170124' into 
> > staging (2017-01-24 17:26:26 +0000)
> >
> > are available in the git repository at:
> >
> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> >
> > for you to fetch changes up to b562d945fc840131d290d4bf5af8d6cc3bb98a2b:
> >
> >   vhost-user: delete chardev on cleanup (2017-01-24 21:49:25 +0200)
> >
> > ----------------------------------------------------------------
> > virtio, vhost, pci: fixes, features
> >
> > generic pci root port support
> > fixes and cleanups all over the place
> >
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
>
> Hi; I'm afraid this fails to build:
>
> /home/pm215/qemu/hw/pci-bridge/gen_pcie_root_port.c:54:9: error:
> implicit declaration of function ‘VMSTATE_PCIE_DEVICE’
> [-Werror=implicit-function-declaration]
>          VMSTATE_PCIE_DEVICE(parent_obj.parent_obj.parent_obj, PCIESlot),
>          ^
> /home/pm215/qemu/hw/pci-bridge/gen_pcie_root_port.c:54:29: error:
> ‘parent_obj’ undeclared here (not in a function)
>          VMSTATE_PCIE_DEVICE(parent_obj.parent_obj.parent_obj, PCIESlot),
>                              ^
> /home/pm215/qemu/hw/pci-bridge/gen_pcie_root_port.c:54:63: error:
> expected expression before ‘PCIESlot’
>          VMSTATE_PCIE_DEVICE(parent_obj.parent_obj.parent_obj, PCIESlot),

Hi Peter,

Strange, I re-based in the same day I posted and compiled just fine...
However, I get the same error using today's master.

I'll fix and re-post the series.

Thanks,
Marcel
                                                                ^
> thanks
> -- PMM