[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 3/9] apic: save apic_delivered flag
From: |
Pavel Dovgalyuk |
Subject: |
Re: [Qemu-devel] [PATCH v8 3/9] apic: save apic_delivered flag |
Date: |
Thu, 26 Jan 2017 16:07:44 +0300 |
> From: Paolo Bonzini [mailto:address@hidden On Behalf Of Paolo Bonzini
> On 26/01/2017 14:03, Pavel Dovgalyuk wrote:
> >> From: Paolo Bonzini [mailto:address@hidden
> >> On 26/01/2017 13:34, Pavel Dovgalyuk wrote:
> >>> This patch implements saving/restoring of static apic_delivered variable.
> >>>
> >>> v8: saving static variable only for one of the APICs
> >>>
> >>> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> >>> ---
> >>> hw/intc/apic_common.c | 37
> >>> +++++++++++++++++++++++++++++++++++++
> >>> include/hw/i386/apic_internal.h | 2 ++
> >>> 2 files changed, 39 insertions(+)
> >>>
> >>> diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
> >>> index d78c885..edacb16 100644
> >>> --- a/hw/intc/apic_common.c
> >>> +++ b/hw/intc/apic_common.c
> >>> @@ -384,6 +384,29 @@ static bool apic_common_sipi_needed(void *opaque)
> >>> return s->wait_for_sipi != 0;
> >>> }
> >>>
> >>> +static bool apic_irq_delivered_needed(void *opaque)
> >>> +{
> >>> + static APICCommonState *first_apic;
> >>> + APICCommonState *s = APIC_COMMON(opaque);
> >>> + if (!first_apic) {
> >>> + first_apic = s;
> >>> + }
> >>> + return s == first_apic;
> >>
> >> Should also check " && apic_irq_delivered != 0".
> >
> > Reset of this variable when machine reboots is also forgotten.
>
> Ok, I'll queue this patch with the condition changed, can you send one
> for reset?
Ok, I'll send it with the next version of the series.
Pavel Dovgalyuk
- Re: [Qemu-devel] [PATCH v8 2/9] icount: exit cpu loop on expire, (continued)
- Re: [Qemu-devel] [PATCH v8 2/9] icount: exit cpu loop on expire, Pavel Dovgalyuk, 2017/01/26
- Re: [Qemu-devel] [PATCH v8 2/9] icount: exit cpu loop on expire, Paolo Bonzini, 2017/01/26
- Re: [Qemu-devel] [PATCH v8 2/9] icount: exit cpu loop on expire, Pavel Dovgalyuk, 2017/01/26
- Re: [Qemu-devel] [PATCH v8 2/9] icount: exit cpu loop on expire, Paolo Bonzini, 2017/01/26
- Re: [Qemu-devel] [PATCH v8 2/9] icount: exit cpu loop on expire, Pavel Dovgalyuk, 2017/01/27
- Re: [Qemu-devel] [PATCH v8 2/9] icount: exit cpu loop on expire, Paolo Bonzini, 2017/01/27
[Qemu-devel] [PATCH v8 3/9] apic: save apic_delivered flag, Pavel Dovgalyuk, 2017/01/26
[Qemu-devel] [PATCH v8 4/9] integratorcp: adding vmstate for save/restore, Pavel Dovgalyuk, 2017/01/26
[Qemu-devel] [PATCH v8 5/9] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2017/01/26
[Qemu-devel] [PATCH v8 6/9] blkreplay: create temporary overlay for underlaying devices, Pavel Dovgalyuk, 2017/01/26
[Qemu-devel] [PATCH v8 7/9] replay: disable default snapshot for record/replay, Pavel Dovgalyuk, 2017/01/26
[Qemu-devel] [PATCH v8 8/9] audio: make audio poll timer deterministic, Pavel Dovgalyuk, 2017/01/26
[Qemu-devel] [PATCH v8 9/9] replay: add record/replay for audio passthrough, Pavel Dovgalyuk, 2017/01/26
Re: [Qemu-devel] [PATCH v8 0/9] replay additions, Paolo Bonzini, 2017/01/26