[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 5/5] checkpatch: reduce MAINTAINERS update m
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH 5/5] checkpatch: reduce MAINTAINERS update message frequency |
Date: |
Thu, 26 Jan 2017 14:28:32 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 26/01/2017 14:11, Thomas Huth wrote:
> This is a port of the following commit from the Linux kernel:
>
> commit e0d975b1b439c4fef58fbc306c542c94f48bb849
> Author: Joe Perches <address@hidden>
> Date: Wed Dec 10 15:51:49 2014 -0800
>
> checkpatch: reduce MAINTAINERS update message frequency
>
> When files are being added/moved/deleted and a patch contains an update to
> the MAINTAINERS file, assume it's to update the MAINTAINERS file correctly
> and do not emit the "does MAINTAINERS need updating?" message.
>
> Reported by many people.
>
> Signed-off-by: Joe Perches <address@hidden>
> Signed-off-by: Andrew Morton <address@hidden>
> Signed-off-by: Linus Torvalds <address@hidden>
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> scripts/checkpatch.pl | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index e1be7b3..555a5b6 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1300,6 +1300,12 @@ sub process {
> }
> }
>
> +# Check if MAINTAINERS is being updated. If so, there's probably no need to
> +# emit the "does MAINTAINERS need updating?" message on file add/move/delete
> + if ($line =~ /^\s*MAINTAINERS\s*\|/) {
> + $reported_maintainer_file = 1;
> + }
> +
> # Check for added, moved or deleted files
> if (!$reported_maintainer_file && !$in_commit_log &&
> ($line =~ /^(?:new|deleted) file mode\s*\d+\s*$/ ||
>
Maybe leave it as a warning given this change?
Paolo
- [Qemu-devel] [RFC PATCH 0/5] checkpatch: Test bad UTF-8 encodings and updates to MAINTAINERS, Thomas Huth, 2017/01/26
- [Qemu-devel] [RFC PATCH 1/5] checkpatch: add a check for utf-8 in commit logs, Thomas Huth, 2017/01/26
- [Qemu-devel] [RFC PATCH 2/5] checkpatch: check utf-8 content from a commit log when it's missing from charset, Thomas Huth, 2017/01/26
- [Qemu-devel] [RFC PATCH 4/5] checkpatch: emit a reminder about MAINTAINERS on file add/move/delete, Thomas Huth, 2017/01/26
- [Qemu-devel] [RFC PATCH 3/5] checkpatch: ignore email headers better, Thomas Huth, 2017/01/26
- [Qemu-devel] [RFC PATCH 5/5] checkpatch: reduce MAINTAINERS update message frequency, Thomas Huth, 2017/01/26
- Re: [Qemu-devel] [RFC PATCH 5/5] checkpatch: reduce MAINTAINERS update message frequency,
Paolo Bonzini <=
- Re: [Qemu-devel] [RFC PATCH 5/5] checkpatch: reduce MAINTAINERS update message frequency, Stefan Hajnoczi, 2017/01/30