[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] dma: omap: check dma channel data_type
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] dma: omap: check dma channel data_type |
|
Date: |
Fri, 27 Jan 2017 15:08:02 +0000 |
On 27 January 2017 at 12:05, P J P <address@hidden> wrote:
> From: Prasad J Pandit <address@hidden>
>
> When setting dma channel 'data_type', if (value & 3) == 3,
> the set 'data_type' is said to be bad. This also leads to an
> OOB access in 'omap_dma_transfer_generic', while doing
> cpu_physical_memory_r/w operations. Add check to avoid it.
>
> Reported-by: Jiang Xin <address@hidden>
> Signed-off-by: Prasad J Pandit <address@hidden>
The data sheet just says the behaviour with value == 3
is "undefined", so I guess this is as good a way as
any other to handle it.
Applied to target-arm.next, thanks.
-- PMM