[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Bug 1660035] [NEW] hw/timer/altera_timer.c:207: bad si
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [Bug 1660035] [NEW] hw/timer/altera_timer.c:207: bad size in memset ? |
|
Date: |
Sat, 28 Jan 2017 14:45:49 +0000 |
On 28 January 2017 at 13:16, dcb <address@hidden> wrote:
> Public bug reported:
>
> hw/timer/altera_timer.c:207:5: warning: ‘memset’ used with length equal
> to number of elements without multiplication by element size [-Wmemset-
> elt-size]
>
> Source code is
>
> memset(t->regs, 0, ARRAY_SIZE(t->regs));
>
> Maybe better code
>
> memset(t->regs, 0, R_MAX * sizeof( uint32_t));
Better still -- just memset(t->regs, 0, sizeof(t->regs));
Chris, could you send a patch to fix this, please?
thanks
-- PMM