[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 2/7] trace: Make trace_get_vcpu_event_count()
From: |
Lluís Vilanova |
Subject: |
Re: [Qemu-devel] [PATCH v7 2/7] trace: Make trace_get_vcpu_event_count() inlinable |
Date: |
Sun, 29 Jan 2017 16:51:26 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Lluís Vilanova writes:
> Richard Henderson writes:
>> On 01/13/2017 12:48 PM, Lluís Vilanova wrote:
>>> @@ -237,7 +237,7 @@ char *trace_opt_parse(const char *optarg);
>>> *
>>> * Return the number of known vcpu-specific events
>>> */
>>> -uint32_t trace_get_vcpu_event_count(void);
>>> +static uint32_t trace_get_vcpu_event_count(void);
>>>
>> Why is this declaration still here? It's redundant with the inline.
> I can remove it if you feel strongly against it, but I kept it to maintain
> consistency with the rest of the file. As I said in the previous series, this
> is
> the style used in the header. All "public" functions (inlined or not) are
> declared there with their documentation.
> Being inlined is an implementation detail (inlines are defined on a separate
> header), but given C's design it leaks through the static declaration.
Ping.
Cheers,
Lluis
- [Qemu-devel] [PATCH v7 0/7] trace: [tcg] Optimize per-vCPU tracing states with separate TB caches, Lluís Vilanova, 2017/01/13
- [Qemu-devel] [PATCH v7 3/7] trace: [tcg] Delay changes to dynamic state when translating, Lluís Vilanova, 2017/01/13
- [Qemu-devel] [PATCH v7 4/7] exec: [tcg] Use different TBs according to the vCPU's dynamic tracing state, Lluís Vilanova, 2017/01/13
- [Qemu-devel] [PATCH v7 5/7] trace: [tcg] Do not generate TCG code to trace dinamically-disabled events, Lluís Vilanova, 2017/01/13
- [Qemu-devel] [PATCH v7 6/7] trace: [tcg, trivial] Re-align generated code, Lluís Vilanova, 2017/01/13
- [Qemu-devel] [PATCH v7 7/7] trace: [trivial] Statically enable all guest events, Lluís Vilanova, 2017/01/13