qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC/RFT PATCH 0/7] cpu-exec: simplify cpu_exec and rem


From: no-reply
Subject: Re: [Qemu-devel] [RFC/RFT PATCH 0/7] cpu-exec: simplify cpu_exec and remove some icount special cases
Date: Sun, 29 Jan 2017 13:18:11 -0800 (PST)

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [RFC/RFT PATCH 0/7] cpu-exec: simplify cpu_exec and 
remove some icount special cases
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
0f5e3df cpu-exec: centralize exiting to the main loop
c58d84e cpu-exec: unify icount_decr and tcg_exit_req
a1bbdfc cpu-exec: remove outermost infinite loop
a984d03 cpu-exec: avoid repeated sigsetjmp on interrupts
0dc98e6 cpu-exec: avoid cpu_loop_exit in cpu_handle_interrupt
218de04 cpu-exec: tighten barrier on TCG_EXIT_REQUESTED
bf63e5a cpu-exec: fix jmp_first out-of-bounds access with icount

=== OUTPUT BEGIN ===
Checking PATCH 1/7: cpu-exec: fix jmp_first out-of-bounds access with icount...
Checking PATCH 2/7: cpu-exec: tighten barrier on TCG_EXIT_REQUESTED...
ERROR: memory barrier without comment
#51: FILE: cpu-exec.c:559:
+        smp_mb();

total: 1 errors, 0 warnings, 13 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/7: cpu-exec: avoid cpu_loop_exit in cpu_handle_interrupt...
Checking PATCH 4/7: cpu-exec: avoid repeated sigsetjmp on interrupts...
Checking PATCH 5/7: cpu-exec: remove outermost infinite loop...
WARNING: line over 80 characters
#51: FILE: cpu-exec.c:633:
+         * Newer versions of gcc would complain about this code (-Wclobbered). 
*/

total: 0 errors, 1 warnings, 68 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/7: cpu-exec: unify icount_decr and tcg_exit_req...
Checking PATCH 7/7: cpu-exec: centralize exiting to the main loop...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]