Re: [Qemu-devel] [PATCH v2] target/s390x: Fix broken user mode

[Peter Maydell]

On 30 January 2017 at 14:10, David Hildenbrand <address@hidden> wrote:
> Am 30.01.2017 um 14:15 schrieb Stefan Weil:
>> Returning NULL from get_max_cpu_model results in a SIGSEGV runtime error.
>>
>> Signed-off-by: Stefan Weil <address@hidden>
>> ---
>>
>> v2: Re-sent as v1 was damaged by my mailer.
>>
>> This is also broken in Debian.
>>
>> In addition, there is no default CPU ("any"), so binfmt and related
>> actions currently don't work. I hacked my local installation by
>> duplicating the "qemu" cpu definition for "any", but maybe there is
>> a better solution.
>
> we have the "qemu" model for that (or simply drop the -cpu parameter
> completely). Eduardo currently proposed "max" as an alternative for x86.
> There is also no "any" model on x86.

"any" isn't quite the same as the proposed "max", necessarily.
For instance on ARM "any" turns on some features which in real
hardware you don't ever see in combination, because for userspace
they don't conflict and this lets us run the widest possible
range of userspace binaries.

If "any" isn't right for s390 then you should fix the code
in linux-user/main.c which picks the default CPU model (for
instance on x86 it selects either "qemu64" or "qemu32").

thanks
-- PMM