|
From: | Pradeep Jagadeesh |
Subject: | Re: [Qemu-devel] [PATCH 1/2 v15] fsdev: add IO throttle support to fsdev devices |
Date: | Fri, 3 Feb 2017 11:33:33 +0100 |
User-agent: | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 2/3/2017 11:10 AM, Alberto Garcia wrote:
On Fri 03 Feb 2017 11:04:57 AM CET, Pradeep Jagadeesh wrote:This patchset adds the io throttle support for the 9p-local driver. For now this functionality can be used only through qemu cli options. QMP interface and support to other 9p drivers need further extensions. To make it simple for other 9p drivers, the throttle code has been put in separate files. Signed-off-by: Pradeep Jagadeesh <address@hidden>I don't see any difference between this patch and the one in v14...
I moved the fsdev_throttle_cleanup() inside the unrealize() function You want me to clean up even here ? out: if (rc) { /* ... */ fsdev_throttle_cleanup(s->ctx.fst); /* ... */ } I thought one place is enough. Or I did not understand your comment :) -Pradeep
+ + s->ctx.fst = &fse->fst; + fsdev_throttle_init(s->ctx.fst); + v9fs_path_free(&path); rc = 0; @@ -3528,6 +3532,7 @@ out: if (s->ops && s->ops->cleanup && s->ctx.private) { s->ops->cleanup(&s->ctx); } + fsdev_throttle_cleanup(s->ctx.fst); g_free(s->tag); g_free(s->ctx.fs_root); v9fs_path_free(&path);Berto
[Prev in Thread] | Current Thread | [Next in Thread] |