[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 kernel 3/5] virtio-balloon: speed up inflate/
From: |
Li, Liang Z |
Subject: |
Re: [Qemu-devel] [PATCH v6 kernel 3/5] virtio-balloon: speed up inflate/deflate process |
Date: |
Sat, 4 Feb 2017 04:35:41 +0000 |
> <snip>
>
> > +static void free_extended_page_bitmap(struct virtio_balloon *vb) {
> > + int i, bmap_count = vb->nr_page_bmap;
> > +
> > + for (i = 1; i < bmap_count; i++) {
> > + kfree(vb->page_bitmap[i]);
> > + vb->page_bitmap[i] = NULL;
> > + vb->nr_page_bmap--;
> > + }
> > +}
> > +
> > +static void kfree_page_bitmap(struct virtio_balloon *vb) {
> > + int i;
> > +
> > + for (i = 0; i < vb->nr_page_bmap; i++)
> > + kfree(vb->page_bitmap[i]);
> > +}
>
> It might be worth commenting that pair of functions to make it clear why
> they are so different; I guess the kfree_page_bitmap is used just before you
> free the structure above it so you don't need to keep the count/pointers
> updated?
>
Yes. I will add some comments for that. Thanks!
Liang
> Dave
> --
> Dr. David Alan Gilbert / address@hidden / Manchester, UK
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v6 kernel 3/5] virtio-balloon: speed up inflate/deflate process,
Li, Liang Z <=