[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification |
Date: |
Mon, 6 Feb 2017 15:46:25 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Mon, Feb 06, 2017 at 01:48:09AM +0000, Gonglei (Arei) wrote:
> > > +\item The device MUST set \field{max_size} to show the maximum size of
> > crypto request the device supports.
> >
> > In bytes?
> >
> > > +\item The device MUST set \field{max_cipher_key_len} to show the
> > maximum length of cipher key if the device supports CIPHER service.
> >
> > In bits or bytes?
> >
> > > +\item The device MUST set \field{max_auth_key_len} to show the maximum
> > length of authenticated key if the device supports MAC service.
> >
> > In bits or bytes?
> >
>
> All lengths in virtio crypto spec are bytes.
Please move this before the first length field is defined:
+\begin{note}
+The basic unit of all data length the byte.
+\end{note}
It should be at the beginning of the spec.
signature.asc
Description: PGP signature