[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 01/10] ACPI: Add a function for building name
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v5 01/10] ACPI: Add a function for building named qword entries |
Date: |
Tue, 7 Feb 2017 14:51:51 +0100 |
On Sun, 5 Feb 2017 01:11:56 -0800
address@hidden wrote:
> From: Ben Warren <address@hidden>
>
> This is initially used to patch a 64-bit address into
> the VM Generation ID SSDT
>
> Signed-off-by: Ben Warren <address@hidden>
> ---
...
> +int
> +build_append_named_qword(GArray *array, const char *name_format, ...)
it ain't used anywhere, I'd just drop this patch.
> +{
> + int offset;
> + va_list ap;
> +
> + build_append_byte(array, 0x08); /* NameOp */
> + va_start(ap, name_format);
> + build_append_namestringv(array, name_format, ap);
> + va_end(ap);
> +
> + build_append_byte(array, 0x0E); /* QWordPrefix */
> +
> + offset = array->len;
> + build_append_int_noprefix(array, 0x0000000000000000, 8);
> + assert(array->len == offset + 8);
> +
> + return offset;
> +}
> +
> static GPtrArray *alloc_list;
>
> static Aml *aml_alloc(void)
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index 559326c..dbf63cf 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -385,6 +385,10 @@ int
> build_append_named_dword(GArray *array, const char *name_format, ...)
> GCC_FMT_ATTR(2, 3);
>
> +int
> +build_append_named_qword(GArray *array, const char *name_format, ...)
> +GCC_FMT_ATTR(2, 3);
> +
> void build_srat_memory(AcpiSratMemoryAffinity *numamem, uint64_t base,
> uint64_t len, int node, MemoryAffinityFlags flags);
>
[Qemu-devel] [PATCH v5 01/10] ACPI: Add a function for building named qword entries, ben, 2017/02/05
- Re: [Qemu-devel] [PATCH v5 01/10] ACPI: Add a function for building named qword entries,
Igor Mammedov <=
[Qemu-devel] [PATCH v5 04/10] ACPI: Add vmgenid storage entries to the build tables, ben, 2017/02/05
[Qemu-devel] [PATCH v5 03/10] docs: VM Generation ID device description, ben, 2017/02/05