[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/28] timer: use an inline function for free
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PATCH 04/28] timer: use an inline function for free |
Date: |
Tue, 7 Feb 2017 17:35:04 +0100 |
On Tue, 7 Feb 2017 17:51:47 +0400
Marc-André Lureau <address@hidden> wrote:
> Similarly to allocation, do it from an inline function. This allows
> tests to only use the headers for allocation/free of timer.
>
> Cc: Paolo Bonzini <address@hidden>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
Reviewed-by: Greg Kurz <address@hidden>
> include/qemu/timer.h | 5 ++++-
> qemu-timer.c | 5 -----
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/include/qemu/timer.h b/include/qemu/timer.h
> index 9abed51ae8..26e628584c 100644
> --- a/include/qemu/timer.h
> +++ b/include/qemu/timer.h
> @@ -610,7 +610,10 @@ void timer_deinit(QEMUTimer *ts);
> *
> * Free a timer (it must not be on the active list)
> */
> -void timer_free(QEMUTimer *ts);
> +static inline void timer_free(QEMUTimer *ts)
> +{
> + g_free(ts);
> +}
>
> /**
> * timer_del:
> diff --git a/qemu-timer.c b/qemu-timer.c
> index ff620ecff7..6cf70b96f6 100644
> --- a/qemu-timer.c
> +++ b/qemu-timer.c
> @@ -355,11 +355,6 @@ void timer_deinit(QEMUTimer *ts)
> ts->timer_list = NULL;
> }
>
> -void timer_free(QEMUTimer *ts)
> -{
> - g_free(ts);
> -}
> -
> static void timer_del_locked(QEMUTimerList *timer_list, QEMUTimer *ts)
> {
> QEMUTimer **pt, *t;
- [Qemu-devel] [PATCH 00/28] Various memory leak fixes, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 02/28] tests: fix qmp response leak, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 01/28] qtest: fix a memory leak, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 03/28] tests: fix leaks in test-io-channel-command, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 04/28] timer: use an inline function for free, Marc-André Lureau, 2017/02/07
- Re: [Qemu-devel] [PATCH 04/28] timer: use an inline function for free,
Greg Kurz <=
- [Qemu-devel] [PATCH 05/28] tests: fix ptimer leaks, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 06/28] tests: fix endianness-test leaks, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 07/28] tests: fix q35-test leaks, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 08/28] tests: fix vhost-user-test leaks, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 09/28] tests: fix ide-test leaks, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 10/28] tests: fix hd-geo-test leaks, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 11/28] tests: fix bios-tables-test leak, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 12/28] tests: fix ipmi-kcs-test leak, Marc-André Lureau, 2017/02/07