Re: [Qemu-devel] [PATCH v2] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

[Laszlo Ersek]

On 02/07/17 20:20, Eric Blake wrote:
> On 12/02/2016 03:01 PM, Laszlo Ersek wrote:
>> When passed to git-diff (and to every other git command producing diffs
>> and/or diffstats) with "-O" or "diff.orderFile", this list of patterns
>> will place the more declarative / abstract hunks first, while changes to
>> imperative code / details will be near the end of the patches. This saves
>> on scrolling / searching and makes for easier reviewing.
>>
>> We intend to advise contributors in the Wiki to run
>>
>>   git config diff.orderFile scripts/git.orderfile
>>
>> once, as part of their initial setup, before formatting their first (or,
>> for repeat contributors, next) patches.
> 
> Presumably, we'd also want this to be mentioned in HACKING?

Presumably. :)

> 
>>
>> See the "-O" option and the "diff.orderFile" configuration variable in
>> git-diff(1) and git-config(1).
>>
>> Cc: "Michael S. Tsirkin" <address@hidden>
>> Cc: Eric Blake <address@hidden>
>> Cc: Fam Zheng <address@hidden>
>> Cc: Gerd Hoffmann <address@hidden>
>> Cc: John Snow <address@hidden>
>> Cc: Max Reitz <address@hidden>
>> Cc: Stefan Hajnoczi <address@hidden>
>> Signed-off-by: Laszlo Ersek <address@hidden>
>> ---
> 
> Is it time to revive this patch?

Time for whom? :)

Cheers,
Laszlo