Re: [Qemu-devel] [PATCH v3 2/8] hw/mips_gictimer: provide API for retrieving frequency

[Philippe Mathieu-Daudé]

On 02/08/2017 01:32 PM, Yongbok Kim wrote:
> From: Paul Burton <address@hidden>
>
> Provide a new function mips_gictimer_get_freq() which returns the
> frequency at which a GIC timer will count. This will be useful for
> boards which perform setup based upon this frequency.
>
> Signed-off-by: Paul Burton <address@hidden>
> Reviewed-by: Leon Alrae <address@hidden>
> Signed-off-by: Yongbok Kim <address@hidden>
> ---
>  hw/timer/mips_gictimer.c         | 5 +++++
>  include/hw/timer/mips_gictimer.h | 1 +
>  2 files changed, 6 insertions(+)
>
> diff --git a/hw/timer/mips_gictimer.c b/hw/timer/mips_gictimer.c
> index 3698889..f5c5806 100644
> --- a/hw/timer/mips_gictimer.c
> +++ b/hw/timer/mips_gictimer.c
> @@ -14,6 +14,11 @@
>
>  #define TIMER_PERIOD 10 /* 10 ns period for 100 Mhz frequency */
>
> +uint32_t mips_gictimer_get_freq(MIPSGICTimerState *gic)
> +{
> +    return NANOSECONDS_PER_SECOND / TIMER_PERIOD;
> +}
> +
>  static void gic_vptimer_update(MIPSGICTimerState *gictimer,
>                                     uint32_t vp_index, uint64_t now)
>  {
> diff --git a/include/hw/timer/mips_gictimer.h b/include/hw/timer/mips_gictimer.h
> index c8bc5d2..c7ca6c8 100644
> --- a/include/hw/timer/mips_gictimer.h
> +++ b/include/hw/timer/mips_gictimer.h
> @@ -31,6 +31,7 @@ struct MIPSGICTimerState {
>      MIPSGICTimerCB *cb;
>  };
>
> +uint32_t mips_gictimer_get_freq(MIPSGICTimerState *gic);
>  uint32_t mips_gictimer_get_sh_count(MIPSGICTimerState *gic);
>  void mips_gictimer_store_sh_count(MIPSGICTimerState *gic, uint64_t count);
>  uint32_t mips_gictimer_get_vp_compare(MIPSGICTimerState *gictimer,

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>