qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] numa: Turn simple union NumaOptions into a


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 1/2] numa: Turn simple union NumaOptions into a flat union
Date: Thu, 09 Feb 2017 08:26:54 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 02/08/2017 10:04 AM, Markus Armbruster wrote:
>> Simple unions are simpler than flat unions in the schema, but more
>> complicated in C and on the QMP wire: there's extra indirection in C
>> and extra nesting on the wire, both pointless.  They're best avoided
>> in new code.
>> 
>> NumaOptions isn't new, but it's only used internally, not in QMP.
>> Convert it to a flat union.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  numa.c           | 4 ++--
>>  qapi-schema.json | 8 ++++++++
>>  2 files changed, 10 insertions(+), 2 deletions(-)
>> 
>
>> +++ b/qapi-schema.json
>> @@ -5545,6 +5545,12 @@
>>              'events' : [ 'InputEvent' ] } }
>>  
>>  ##
>> +# @NumaOptionsType:
>> +##
>
> Do we want a 'Since: 2.1' designation (since the enum has effectively
> existed, even if implicitly, for as long as NumaOptions has been around)?

Version tracking is useful only for things visible external interfaces,
which this is not.  Tool support to require it for external and reject
it for internal stuff would be nice.  Until then, we need to rely on
review to get external stuff tracked properly.

Tracking internal stuff is busywork.  If we think it's less work than
deciding internal vs. external, we can slap on "Since:" blindly.

> With or without that extra line,
> Reviewed-by: Eric Blake <address@hidden>

Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]