|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH] tcg: handle EXCP_ATOMIC exception properly |
Date: | Fri, 10 Feb 2017 13:15:19 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 10/02/2017 13:13, Alex Bennée wrote: >> + if (atomic_read(&other_cpu->running) && >> !qemu_cpu_is_self(other_cpu)) { > The comment above reads: > > Must only be called from outside cpu_exec. > > So we need to revise this comment. Is this really a limitation or was it > originally the design goal? If you want to call it within cpu_exec, you can always use cpu_exec_end/start around it. I think we should first of all get rid of the iothread lock within cpu_exec, and then look at this patch again. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |