[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID
From: |
Andrew Jones |
Subject: |
Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID |
Date: |
Fri, 10 Feb 2017 19:18:52 +0100 |
User-agent: |
Mutt/1.6.0.1 (2016-04-01) |
On Fri, Feb 10, 2017 at 05:16:59PM +0100, Igor Mammedov wrote:
> On Fri, 10 Feb 2017 17:31:33 +0200
> "Michael S. Tsirkin" <address@hidden> wrote:
>
> > On Fri, Feb 10, 2017 at 11:12:13AM +0100, Laszlo Ersek wrote:
> > > On 02/05/17 10:11, address@hidden wrote:
> > > > From: Ben Warren <address@hidden>
> [...]
>
> > >
> > > - or else, add another boolean property to vmgenid, one that parallels
> > > "dma-enabled" of "fw-cfg" precisely, in HW_COMPAT*. Then simply fail
> > > realize() when this property is false.
> >
> > That's probably the easiest way. x-fw-cfg-dma-enabled.
> > Won't delay merging because of this, can be done with
> > patch on top.
> (not related to this series)
>
> I've thought that there still were no consensus on x-foo prefix,
> not to mention that x- might be legitimate prefix for some properties.
>
> Maybe we should add a flag to property like INTERNAL_PROPERTY
> and then set it explicitly on for internal stuff.
>
> That way we could cleanly exclude internal properties from
> -device foo,help and make sure that user won't set them from CLI.
> I'd even volunteer to add this API to Object
Yes, please. I know of a property or two where it would be nice to
have that flag.
Thanks,
drew
>
>
- [Qemu-devel] [PATCH v5 06/10] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands, (continued)
- [Qemu-devel] [PATCH v5 06/10] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands, ben, 2017/02/05
- [Qemu-devel] [PATCH v5 07/10] qmp/hmp: add set-vm-generation-id commands, ben, 2017/02/05
- [Qemu-devel] [PATCH v5 09/10] tests: Move reusable ACPI macros into a new header file, ben, 2017/02/05
- [Qemu-devel] [PATCH v5 10/10] tests: Add unit tests for the VM Generation ID feature, ben, 2017/02/05
- Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID, Laszlo Ersek, 2017/02/10
- Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID, Igor Mammedov, 2017/02/10
- Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID, Michael S. Tsirkin, 2017/02/10
- Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID, Igor Mammedov, 2017/02/10
- Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID,
Andrew Jones <=
- Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID, Andreas Färber, 2017/02/10
- Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID, Igor Mammedov, 2017/02/13
- Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID, Michael S. Tsirkin, 2017/02/13
- Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID, Igor Mammedov, 2017/02/13