qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] nios2: Add Altera JTAG UART emulation


From: Bystricky, Juro
Subject: Re: [Qemu-devel] [PATCH] nios2: Add Altera JTAG UART emulation
Date: Mon, 13 Feb 2017 00:55:01 +0000


> Subject should contain [PATCH v5] ...

mea culpa, to my defense I did specify --subject-prefix="PATCH v5" 
but did not realize "git send-email file.patch" seems to ignore it

Normally I do something like this (which works fine):
"git send-email -1 --subject-prefix="PATCH v5" 


[...]

> > +         * We do not decrement the write fifo,
> > +         * we "tranmsmit" instanteniously, CONTROL_WI always asserted
> 
> Nit, fix this comment (transmit, instantly) and it's alignment.
> 
> I don't quite understand what this comment is trying to tell me though.
>
comment removed as too confusing

> > +    /*
> > +     * FIFO size can be set from 8 to 32,768 bytes.
> > +     * Only powers of two are allowed.
> > +     */
> > +    if (fifo_size < 8 || fifo_size > 3276 || (fifo_size & ~(1 <<
> ctz32(fifo_size)))) {
> 
> 32768 , not 3276 ...

Thanks, good catch. Fixed.

[...]

> > +void altera_juart_create(int channel, const hwaddr addr, qemu_irq irq,
> > +                                                        uint32_t
> fifo_size);
> 
> Fix the alignment here so it doesn't look so braindead, align under the
> first open parenthesis.
> 

Fixed

Thanks

Juro

reply via email to

[Prev in Thread] Current Thread [Next in Thread]