[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] 答复： Re: [PATCH v2 RESEND] Makefile: Fix owner and gro
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] 答复： Re: [PATCH v2 RESEND] Makefile: Fix owner and group for qemu-version.h.tmp |
|
Date: |
Mon, 13 Feb 2017 12:55:37 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 13/02/2017 12:53, Lin Ma wrote:
>
> The content of qemu-version.h recorded the git head info of last build.
> After 'git pull && make ', Because the content of qemu-version.h.tmp is
> generated
> based on the lastest git describe, Now this .h.tmp and the old .h aren't
> consistent,
> So this .h.tmp will be renamed to qemu-version.h.
> Then during 'sudo make install', because there is no .h.tmp any more, a
> new one will be
> generated with privileged permissions.
So is the bug that the "cmp || mv" should be changed to "if cmp ...;
then mv ...; else rm ..."?
Paolo