Re: [Qemu-devel] [PATCH 7/8] slirp: VMStatify socket level

[Juan Quintela]

"Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Working up the stack, this replaces the slirp_socket_load/save
> with VMState definitions.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>

Reviewed-by: Juan Quintela <address@hidden>


> diff --git a/slirp/socket.h b/slirp/socket.h
> index 8feed2a..0137928 100644
> --- a/slirp/socket.h
> +++ b/slirp/socket.h
> @@ -30,7 +30,7 @@ struct socket {
>                                   * PING reply's */
>    struct tcpiphdr *so_ti;       /* Pointer to the original ti within
>                                   * so_mconn, for non-blocking connections */
> -  int so_urgc;
> +  uint32_t      so_urgc;
>    union {   /* foreign host */
>        struct sockaddr_storage ss;
>        struct sockaddr_in sin;
> @@ -56,8 +56,8 @@ struct socket {
>    uint8_t    so_iptos;       /* Type of service */
>    uint8_t    so_emu;         /* Is the socket emulated? */
>  
> -  u_char     so_type;                /* Type of socket, UDP or TCP */
> -  int        so_state;               /* internal state flags SS_*, below */
> +  uint8_t       so_type;        /* Type of socket, UDP or TCP */
> +  int32_t       so_state;       /* internal state flags SS_*, below */
>  
>    struct     tcpcb *so_tcpcb;        /* pointer to TCP protocol control 
> block */
>    u_int      so_expire;              /* When the socket will expire */

I normally preffer to fix types in a previous patch, but that is clearly
a question of taste.

Later, Juan.