Re: [Qemu-devel] [PATCH 1/1] mirror: do not increase offset during initial zero_or_discard phase - pls consider this as V3 patch

[Denis V. Lunev]

On 02/13/2017 10:13 PM, Jeff Cody wrote:
> On Mon, Feb 13, 2017 at 06:16:36PM +0100, Max Reitz wrote:
>> On 13.02.2017 08:10, Denis V. Lunev wrote:
>>> On 02/03/2017 06:08 PM, Denis V. Lunev wrote:
>>>> On 02/03/2017 06:06 PM, Denis V. Lunev wrote:
>>>>> From: Anton Nefedov <address@hidden>
>>>>>
>>>>> If explicit zeroing out before mirroring is required for the target image,
>>>>> it moves the block job offset counter to EOF, then offset and len counters
>>>>> count the image size twice. There is no harm but stats are confusing,
>>>>> specifically the progress of the operation is always reported as 99% by
>>>>> management tools.
>>>>>
>>>>> The patch skips offset increase for the first "technical" pass over the
>>>>> image. This should not cause any further harm.
>>>>>
>>>>> Signed-off-by: Anton Nefedov <address@hidden>
>>>>> Signed-off-by: Denis V. Lunev <address@hidden>
>>>>> Reviewed-by: Eric Blake <address@hidden>
>>>>> Reviewed-by: Stefan Hajnoczi <address@hidden>
>>>>> CC: Jeff Cody <address@hidden>
>>>>> CC: Kevin Wolf <address@hidden>
>>>>> CC: Max Reitz <address@hidden>
>>>> actually this is V3 patch. Sorry for broken subject.
>>>>
>>>> Den
>>> ping
>> Didn't Jeff merge v2?
>>
>> http://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg01319.html
>>
>> Max
>>
>
> Yes, I did.
thank you very much for clarification

Den