[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] audio: make audio poll timer deterministic
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v3] audio: make audio poll timer deterministic |
Date: |
Tue, 14 Feb 2017 12:59:22 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 14/02/2017 08:15, Pavel Dovgalyuk wrote:
> This patch changes resetting strategy of the audio polling timer.
> It does not change expiration time if the timer is already set.
> This patch is needed to make this timer deterministic and to use execution
> record/replay for audio devices.
>
> audio_reset_timer is used in the function audio_vm_change_state_handler.
> Therefore every time VM is stopped or restarted the timer will be reset
> to new timeout. Virtual clock does not proceed while VM is stopped.
> Therefore there is no need in resetting the timeout when VM restarts.
>
> v2: updated commit message
> v3: now using timer_mod_anticipate function (as suggested by Yurii Zubrytskyi)
Gerd, feel free to pick either v2 or v3.
Paolo