[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH] backup: allow target without .bdrv
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH] backup: allow target without .bdrv_get_info |
|
Date: |
Tue, 14 Feb 2017 13:35:05 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/14/2017 09:05 AM, Fam Zheng wrote:
>> Proposed NBD protocol extension - NBD_OPT_INFO should finally solve this
>> problem.
>> But until it is not realized, we need allow backup to nbd target due to
>> backward
>> compatibility.
>>
>> Furthermore, is it entirely ok to disallow backup if bds lacks
>> .bdrv_get_info?
>> Which behavior should be default: to fail backup or to use default cluster
>> size?
>>
>
> Target not having .bdrv_get_info means 'some sane assumptions are okay' to
> me, so
>
> Reviewed-by: Fam Zheng <address@hidden>
>
> (But we are going to have a .bdrv_get_info after NBD_OPT_INFO, right?)
Yes. I'm reposting that series today.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature