qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/24] tests/test-qemu-opts: Cover qemu_opts_par


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 01/24] tests/test-qemu-opts: Cover qemu_opts_parse()
Date: Tue, 14 Feb 2017 13:48:10 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0

On 02/14/2017 04:25 AM, Markus Armbruster wrote:
> The new tests demonstrate a few bugs, all clearly marked.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  tests/test-qemu-opts.c | 294 
> ++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 292 insertions(+), 2 deletions(-)

> 
> +
> +    /* Anti-social ID */
> +    opts = qemu_opts_parse(&opts_list_01, "id=666", false, &err);

Love it. It's always fun to see cute references in a testsuite.

Obviously, the rest of this series cleans up the messes you've
uncovered.  Some of those new tests are pretty embarrassing.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]