[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/24] tests/test-qemu-opts: Cover qemu_opts_par
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 01/24] tests/test-qemu-opts: Cover qemu_opts_parse() |
Date: |
Tue, 14 Feb 2017 13:48:10 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/14/2017 04:25 AM, Markus Armbruster wrote:
> The new tests demonstrate a few bugs, all clearly marked.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/test-qemu-opts.c | 294
> ++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 292 insertions(+), 2 deletions(-)
>
> +
> + /* Anti-social ID */
> + opts = qemu_opts_parse(&opts_list_01, "id=666", false, &err);
Love it. It's always fun to see cute references in a testsuite.
Obviously, the rest of this series cleans up the messes you've
uncovered. Some of those new tests are pretty embarrassing.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 19/24] tests/test-cutils: Drop suffix from test_qemu_strtosz_simple(), (continued)
- [Qemu-devel] [PATCH 17/24] util/cutils: Drop QEMU_STRTOSZ_DEFSUFFIX_* macros, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 05/24] util/cutils: Rewrite documentation of qemu_strtol() & friends, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 14/24] util/cutils: New qemu_strtosz_metric(), Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 01/24] tests/test-qemu-opts: Cover qemu_opts_parse(), Markus Armbruster, 2017/02/14
- Re: [Qemu-devel] [PATCH 01/24] tests/test-qemu-opts: Cover qemu_opts_parse(),
Eric Blake <=
- [Qemu-devel] [PATCH 18/24] tests/test-cutils: Use qemu_strtosz() more often, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 12/24] tests/test-cutils: Cover qemu_strtosz() with trailing crap, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 03/24] tests/test-cutils: Add missing qemu_strtol()... endptr checks, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 02/24] QemuOpts: Assert value string isn't null, Markus Armbruster, 2017/02/14