[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/24] util/cutils: Clean up variable names arou
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 07/24] util/cutils: Clean up variable names around qemu_strtol() |
Date: |
Tue, 14 Feb 2017 15:37:54 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/14/2017 04:25 AM, Markus Armbruster wrote:
> Name same things the same, different things differently.
>
> * qemu_strtol()'s parameter @nptr is called @p in
> check_strtox_error(). Rename the latter.
>
> * qemu_strtol()'s parameter @endptr is called @next in
> check_strtox_error(). Rename the latter.
>
> * qemu_strtol()'s variable @p is called @endptr in
> check_strtox_error(). Rename both to @ep.
>
> * qemu_strtol()'s variable @err is *negative* errno,
> check_strtox_error()'s parameter @err is *positive*. Rename the
> latter to @eno.
Whether or not you rename @eno based on Paolo's comments,
>
> Same for qemu_strtoul(), qemu_strtoi64(), qemu_strtou64(), of course.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> util/cutils.c | 42 +++++++++++++++++++++---------------------
> 1 file changed, 21 insertions(+), 21 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 12/24] tests/test-cutils: Cover qemu_strtosz() with trailing crap, (continued)
- [Qemu-devel] [PATCH 03/24] tests/test-cutils: Add missing qemu_strtol()... endptr checks, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 02/24] QemuOpts: Assert value string isn't null, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 07/24] util/cutils: Clean up variable names around qemu_strtol(), Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 15/24] util/cutils: Rename qemu_strtosz() to qemu_strtosz_mebi(), Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 16/24] util/cutils: New qemu_strtosz(), Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 23/24] util/cutils: Change qemu_strtosz*() from int64_t to uint64_t, Markus Armbruster, 2017/02/14