Re: [Qemu-devel] [PATCH] hw/acpi/tco.c: fix tco timer stop

[Michael Tokarev]

06.02.2017 17:44, Igor Pavlikevich wrote:
> TCO timer does not actually stop
> 
> Signed-off-by: Igor Pavlikevich <address@hidden>
> ---
>  hw/acpi/tco.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/acpi/tco.c b/hw/acpi/tco.c
> index 8ce7daf..b4adac8 100644
> --- a/hw/acpi/tco.c
> +++ b/hw/acpi/tco.c
> @@ -49,6 +49,7 @@ static inline void tco_timer_reload(TCOIORegs *tr)
>  static inline void tco_timer_stop(TCOIORegs *tr)
>  {
>      tr->expire_time = -1;
> +    timer_del(tr->tco_timer);
>  }
> 
>  static void tco_timer_expired(void *opaque)
> 

I'm not sure this is really trivial change.
Can you elaborate a bit please?

And please Cc qemu-devel@ too (doing this now).

Thanks,

/mjt