[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: consolidate VMStateField.start
From: |
Halil Pasic |
Subject: |
Re: [Qemu-devel] [PATCH] migration: consolidate VMStateField.start |
Date: |
Wed, 15 Feb 2017 12:42:12 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/11/2017 05:26 AM, Philippe Mathieu-Daudé wrote:
> On 02/10/2017 12:24 PM, Dr. David Alan Gilbert wrote:
>> * Halil Pasic (address@hidden) wrote:
>>> The member VMStateField.start is used for two things, partial data
>>> migration for VBUFFER data (basically provide migration for a
>>> sub-buffer) and for locating next in QTAILQ.
>>>
>>> The implementation of the VBUFFER feature is broken when VMSTATE_ALLOC
>>> is used. This however goes unnoticed because actually partial migration
>>> for VBUFFER is not used at all.
>>>
>>> Let's consolidate the usage of VMStateField.start by removing support
>>> for partial migration for VBUFFER.
>>>
>>> Signed-off-by: Halil Pasic <address@hidden>
>>
>> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>>
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Thanks for the review Philippe!
@Maintainers: Softfreeze is approaching, and I would like to try
get my 'array of pointers with null pointers' (which is on top of
this) in 2.9 too if possible. Anything I can do to speed things up?
Regards,
Halil