Re: [Qemu-devel] [PATCH] migration: consolidate VMStateField.start

[Halil Pasic]

On 02/15/2017 12:46 PM, Dr. David Alan Gilbert wrote:
> * Halil Pasic (address@hidden) wrote:
>>
>>
>> On 02/11/2017 05:26 AM, Philippe Mathieu-Daudé wrote:
>>> On 02/10/2017 12:24 PM, Dr. David Alan Gilbert wrote:
>>>> * Halil Pasic (address@hidden) wrote:
>>>>> The member VMStateField.start is used for two things, partial data
>>>>> migration for VBUFFER data (basically provide migration for a
>>>>> sub-buffer) and for locating next in QTAILQ.
>>>>>
>>>>> The implementation of the VBUFFER feature is broken when VMSTATE_ALLOC
>>>>> is used. This however goes unnoticed because actually partial migration
>>>>> for VBUFFER is not used at all.
>>>>>
>>>>> Let's consolidate the usage of VMStateField.start by removing support
>>>>> for partial migration for VBUFFER.
>>>>>
>>>>> Signed-off-by: Halil Pasic <address@hidden>
>>>>
>>>> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>>>>
>>>
>>> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>>
>> Thanks for the review Philippe!
>>
>> @Maintainers: Softfreeze is approaching, and I would like to try
>> get my 'array of pointers with null pointers' (which is on top of
>> this) in 2.9 too if possible. Anything I can do to speed things up?
> 
> It went in on Monday!
> 
> Dave

Thank you very much!

Halil

> 
>> Regards,
>> Halil
>>
> --
> Dr. David Alan Gilbert / address@hidden / Manchester, UK
>