Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

[Eric Blake]

[meta-comment]

On 02/16/2017 05:10 AM, Igor Mammedov wrote:
> On Wed, 15 Feb 2017 11:19:44 -0800
> Ben Warren <address@hidden> wrote:
> 
>>> On Feb 15, 2017, at 11:14 AM, Ben Warren <address@hidden> wrote:
...
>>>>>>>>>>>>> This is similar to the existing 'add pointer' functionality, but 
>>>>>>>>>>>>> instead

13 levels of quoting...

>>>> +        char pad[120];  
>>> wr_pointer is 121 (56 + 56 + 32 + 32 + 1), so 124 still makes sense, 
>>> doesn’t it? (also, 124 + 4 from command) % 8 == 0, so it’s nicely aligned.  
>> I mean (56 + 56 + 4 + 4 + 1), of course :)
> I' was wrong, as Laszlo pointed out pad is a member of union so it
> as the biggest member defines total size of union/struct
> as far as new command doesn't exceed 124 bytes size.

...and several pages of scrolling before I find the 3-line real content
of the message...

>>>>>>>>>>>>> #endif          

...buried by yet more scrolling through excessive quoting.  It's not
only okay, but ENCOURAGED, to trim your replies down to the relevant
portions (as I've done here), to quickly call attention to the content
you are adding to the thread.  Publicly archived lists have the benefit
that you don't have to full-quote the entire thread, because readers
interested in trimmed content can refer to the archives.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature