Re: [Qemu-devel] [PATCH 15/17] iotests: add default node-name

[Vladimir Sementsov-Ogievskiy]

16.02.2017 16:48, Fam Zheng wrote:
> On Mon, 02/13 12:54, Vladimir Sementsov-Ogievskiy wrote:
> > When testing migration, auto-generated by qemu node-names differs in
> > source and destination qemu and migration fails. After this patch,
> > auto-generated by iotest nodenames will be the same.
> What should be done in libvirt to make sure the node-names are matching
> correctly at both sides?

Hmm, just set node names appropriately?

> > Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> > Reviewed-by: Max Reitz <address@hidden>
> > ---
> >   tests/qemu-iotests/iotests.py | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> > index f5ca4b8..e110c90 100644
> > --- a/tests/qemu-iotests/iotests.py
> > +++ b/tests/qemu-iotests/iotests.py
> > @@ -168,6 +168,8 @@ class VM(qtest.QEMUQtestMachine):
> >               options.append('file=%s' % path)
> >               options.append('format=%s' % format)
> >               options.append('cache=%s' % cachemode)
> > +            if 'node-name' not in opts:
> > +                options.append('node-name=drivenode%d' % self._num_drives)
> >   
> >           if opts:
> >               options.append(opts)
> > --
> > 1.8.3.1


--
Best regards,
Vladimir