[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] qemu-img: Add tests for raw image prealloca
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/3] qemu-img: Add tests for raw image preallocation |
|
Date: |
Fri, 17 Feb 2017 15:27:27 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 17.02.2017 um 15:20 hat Nir Soffer geschrieben:
> On Fri, Feb 17, 2017 at 11:14 AM, Kevin Wolf <address@hidden> wrote:
> > Am 17.02.2017 um 01:51 hat Nir Soffer geschrieben:
> >> Add tests for creating raw image with and without the preallocation
> >> option.
> >>
> >> Signed-off-by: Nir Soffer <address@hidden>
> >
> > Looks good, but 175 is already (multiply) taken. Not making this a
> > blocker, but I just want to remind everyone to check the mailing list
> > for pending patches which add new tests before using a new number in
> > order to avoid unnecessary rebases for everyone. In general, it's as
> > easy as searching for the string "175.out" in the mailbox.
> >
> > The next free one seems to be 177 currently.
>
> Thanks, will change to 177 in the next version.
If there needs to be a next version for other reasons. Otherwise it's
not important enough to respin, it just means that someone else will
have to rebase.
> For next patches, what do you mean by "pending"? patches sent
> to the block mailing list?
Yes, that's what I'm looking for when I add a new test case myself. It's
just an easy way to avoid stepping on each others toes.
Kevin