[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi ra
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D |
Date: |
Fri, 17 Feb 2017 09:55:23 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/17/2017 09:52 AM, Peter Maydell wrote:
>>> Makefile | 17 ++++++++++-------
>>> docs/qemu-ga-ref.texi | 2 ++
>>> docs/qemu-qmp-ref.texi | 2 ++
>>> 3 files changed, 14 insertions(+), 7 deletions(-)
>>
>> Missing a change to .gitignore for version.texi.
>
> Should be
> --- a/.gitignore
> +++ b/.gitignore
> @@ -107,6 +107,7 @@ docs/qemu-ga-ref.info*
> docs/qemu-qmp-ref.info*
> /qemu-ga-qapi.texi
> /qemu-qapi.texi
> +/version.texi
> *.tps
> .stgit-*
> cscope.*
>
> right?
Yes, that looks right.
(Hmm - another file stuck in the top-level directory; a separate patch
might be worth sticking some of these generated .texi files under docs/
instead)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature