[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tests: Use error_free_or_abort() where appropri
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] tests: Use error_free_or_abort() where appropriate |
|
Date: |
Fri, 17 Feb 2017 14:39:00 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/17/2017 02:15 PM, Markus Armbruster wrote:
> Done with this Coccinelle semantic patch:
>
> @@
> expression E;
> @@
> - g_assert(E);
> - error_free(E);
> + error_free_or_abort(&E);
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/test-qemu-opts.c | 3 +--
> tests/test-qobject-output-visitor.c | 6 ++----
> 2 files changed, 3 insertions(+), 6 deletions(-)
Nice that it doesn't find many uses (it means we've already swept the
tests for this pattern manually).
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature