Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

[Daniel P. Berrange]

On Sat, Feb 18, 2017 at 12:30:31AM +0000, Ketan Nilangekar wrote:
> On 2/17/17, 1:42 PM, "Jeff Cody" <address@hidden> wrote:
> 
>     On Thu, Feb 16, 2017 at 02:24:19PM -0800, ashish mittal wrote:
>     > Hi,
>     > 
>     > I am getting the following error with checkpatch.pl
>     > 
>     > ERROR: externs should be avoided in .c files
>     > #78: FILE: block/vxhs.c:28:
>     > +QemuUUID qemu_uuid __attribute__ ((weak));
>     > 
>     > Is there any way to get around this, or does it mean that I would have
>     > to add a vxhs.h just for this one entry?
>     >
>     
>     I remain skeptical on the use of the qemu_uuid as a way to select the TLS
>     cert.
> 
> [ketan]
> Is there another identity that can be used for uniquely identifying instances?
> The requirement was to enforce vdisk access to owner instances.

The UUID is a bad way to do any kind of access control as QEMU could simply
lie about its UUID.

If the server needs to identify the client to do access control you need
something non-spoofable. In the absence of having an authentication protocol
built into the libqnio protocol, the best you could do would be to use the
TLS client certificate distinguished name. QEMU can't lie about that without
having access to the other certificate file - which would be blocked by
SELinux

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|