Re: [Qemu-devel] [PATCH] qemu-option: reject empty number value

[Markus Armbruster]

Marc-André Lureau <address@hidden> writes:

> When no number is provided, return an invalid number error.
> (note: this may break some users relying on default 0 value)
>
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=1417864
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  util/qemu-option.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/qemu-option.c b/util/qemu-option.c
> index 3467dc2397..89afa4b2c3 100644
> --- a/util/qemu-option.c
> +++ b/util/qemu-option.c
> @@ -150,7 +150,7 @@ static void parse_option_number(const char *name, const 
> char *value,
>  
>      if (value != NULL) {
>          number = strtoull(value, &postfix, 0);
> -        if (*postfix != '\0') {
> +        if (*postfix != '\0' || postfix == value) {
>              error_setg(errp, QERR_INVALID_PARAMETER_VALUE, name, "a number");
>              return;
>          }

My "[PATCH 09/24] QemuOpts: Fix to reject numbers that overflow
uint64_t" is a more comprehensive fix, even though I missed this case
both in the tests and the commit message.  I'll take care of that in v2.

Thanks!