Re: [Qemu-devel] [PATCH v9 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

[Jeff Cody]

On Feb 20, 2017 8:49 AM, "Paolo Bonzini" <address@hidden> wrote:



On 20/02/2017 11:07, Daniel P. Berrange wrote:
>> +        if (qemu_uuid_is_null(&qemu_uuid)) {
> This is the wrong check - QEMU provides a 'qemu_uuid_set' boolean
> to determine if 'qemu_uuid' is set or not. If it is not set, then
> the code should return an error, not use a hardcoded uuid.

Or otherwise that hardcoded uuid should be all zeroes (UUID_NONE).



(Replying from phone, sorry for formatting issues)

I think the issue is that boolean is not defined when linking qemu-img, so
if it is used in vxhs.c there will be a linking error.  I can't test that
hypothesis right now, though, as I am traveling.

This also ties into the TLS certs, I believe.  The uuid is being used by
libqnio to determine the cert path, to allow/disallow certain operations
based on if it is being called by qemu-img/io or qemu, etc.





>> +            if (iio_init(QNIO_VERSION, vxhs_iio_callback,
VXHS_UUID_DEF)) {
>> +                return -ENODEV;
>> +            }