Re: [Qemu-devel] [PATCH v1 03/10] target/ppc: move subf logic block

[Richard Henderson]

On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote:
>              tcg_gen_andi_tl(cpu_ca, cpu_ca, 1);
> -        } else if (add_ca) {
> -            TCGv zero, inv1 = tcg_temp_new();
> -            tcg_gen_not_tl(inv1, arg1);
> -            zero = tcg_const_tl(0);
> -            tcg_gen_add2_tl(t0, cpu_ca, arg2, zero, cpu_ca, zero);
> -            tcg_gen_add2_tl(t0, cpu_ca, t0, cpu_ca, inv1, zero);
> -            tcg_temp_free(zero);
> -            tcg_temp_free(inv1);
>          } else {
> -            tcg_gen_setcond_tl(TCG_COND_GEU, cpu_ca, arg2, arg1);
> -            tcg_gen_sub_tl(t0, arg2, arg1);
> +            if (add_ca) {
> +                TCGv zero, inv1 = tcg_temp_new();
> +                tcg_gen_not_tl(inv1, arg1);
> +                zero = tcg_const_tl(0);
> +                tcg_gen_add2_tl(t0, cpu_ca, arg2, zero, cpu_ca, zero);
> +                tcg_gen_add2_tl(t0, cpu_ca, t0, cpu_ca, inv1, zero);
> +                tcg_temp_free(zero);
> +                tcg_temp_free(inv1);
> +            } else {
> +                tcg_gen_setcond_tl(TCG_COND_GEU, cpu_ca, arg2, arg1);
> +                tcg_gen_sub_tl(t0, arg2, arg1);
> +            }
>          }

Why would you want to increase the indentation for no reason?


r~