[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] qapi: flatten GuestPanicInformation union
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] qapi: flatten GuestPanicInformation union |
Date: |
Mon, 20 Feb 2017 13:48:45 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/20/2017 12:21 PM, Denis V. Lunev wrote:
> From: Anton Nefedov <address@hidden>
>
> Signed-off-by: Anton Nefedov <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> CC: Eric Blake <address@hidden>
> ---
> qapi-schema.json | 12 ++++++++++++
> target/i386/cpu.c | 15 ++++++---------
> vl.c | 12 ++++++------
> 3 files changed, 24 insertions(+), 15 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index e9a6364..b142e15 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -5872,6 +5872,16 @@
> 'data': [ 'pause', 'poweroff' ] }
>
> ##
> +# @GuestPanicInformationType:
> +#
> +# An enumeration of the guest panic information types
> +#
> +# Since: 2.9
> +##
> +{ 'enum': 'GuestPanicInformationType',
> + 'data': [ 'hyper-v'] }
Perhaps 'hyperv' is better? It's the difference between
GUEST_PANIC_INFORMATION_TYPE_HYPER_V and
GUEST_PANIC_INFORMATION_TYPE_HYPERV. But that's bikeshedding, so no need
to change it.
Must go into 2.9, so we aren't baking in bad API.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature