[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/14] libqtest: Clean up qmp_response() a bit
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 05/14] libqtest: Clean up qmp_response() a bit |
|
Date: |
Mon, 20 Feb 2017 20:48:41 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/17/2017 02:38 PM, Markus Armbruster wrote:
> Use qobject_to_qdict() instead of a type cast.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/libqtest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Happens to be the same (because of our struct layout), but agree that
the conversion function is safer if we ever change struct layout.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 10/14] tests: Don't check qobject_type() before qobject_to_qint(), (continued)
- [Qemu-devel] [PATCH 07/14] Don't check qobject_type() before qobject_to_qdict(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 09/14] tests: Don't check qobject_type() before qobject_to_qstring(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 03/14] check-qdict: Tighten qdict_crumple_test_recursive() some, Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 13/14] monitor: Clean up handle_hmp_command() a bit, Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 05/14] libqtest: Clean up qmp_response() a bit, Markus Armbruster, 2017/02/17
- Re: [Qemu-devel] [PATCH 05/14] libqtest: Clean up qmp_response() a bit,
Eric Blake <=
- [Qemu-devel] [PATCH 04/14] check-qjson: Simplify around compare_litqobj_to_qobj(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 08/14] tests: Don't check qobject_type() before qobject_to_qlist(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 14/14] block: Don't bother asserting type of output visitor's output, Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 12/14] tests: Don't check qobject_type() before qobject_to_qbool(), Markus Armbruster, 2017/02/17