[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v3 04/15] vfio: ccw: basic implementation fo
From: |
Dong Jia Shi |
Subject: |
Re: [Qemu-devel] [PATCH RFC v3 04/15] vfio: ccw: basic implementation for vfio_ccw driver |
Date: |
Tue, 21 Feb 2017 15:43:02 +0800 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
* Dong Jia Shi <address@hidden> [2017-02-21 15:36:23 +0800]:
[...]
> > > +static int vfio_ccw_sch_probe(struct subchannel *sch)
> > > +{
> > > + struct pmcw *pmcw = &sch->schib.pmcw;
> > > + struct vfio_ccw_private *private;
> > > + int ret;
> > > +
> > > + if (pmcw->qf) {
> > > + dev_warn(&sch->dev, "vfio: ccw: do not support QDIO: %s\n",
> >
> > s/do/does/
> >
> Ok.
>
> > > + dev_name(&sch->dev));
> > > + return -ENOTTY;
> >
> > Is -ENOTTY the right return code here? -EINVAL?
> >
> Ok. Think it again. -EINVAL makes more sense. It's like:
> "hey, I know it's an I/O subchannel, but not the kind we support".
>
Or -ENOTSUPP ?
> > > + }
> > > +
[...]
--
Dong Jia
[Qemu-devel] [PATCH RFC v3 05/15] vfio: ccw: introduce channel program interfaces, Dong Jia Shi, 2017/02/17
[Qemu-devel] [PATCH RFC v3 06/15] vfio: ccw: register vfio_ccw to the mediated device framework, Dong Jia Shi, 2017/02/17
[Qemu-devel] [PATCH RFC v3 08/15] vfio: ccw: handle ccw command request, Dong Jia Shi, 2017/02/17
[Qemu-devel] [PATCH RFC v3 07/15] vfio: ccw: introduce ccw_io_region, Dong Jia Shi, 2017/02/17
[Qemu-devel] [PATCH RFC v3 10/15] vfio: ccw: realize VFIO_DEVICE_RESET ioctl, Dong Jia Shi, 2017/02/17
[Qemu-devel] [PATCH RFC v3 09/15] vfio: ccw: realize VFIO_DEVICE_GET_REGION_INFO ioctl, Dong Jia Shi, 2017/02/17
[Qemu-devel] [PATCH RFC v3 11/15] vfio: ccw: realize VFIO_DEVICE_G(S)ET_IRQ_INFO ioctls, Dong Jia Shi, 2017/02/17