Re: [Qemu-devel] [PATCH] vnc: fix double free issues

[Marc-André Lureau]

On Tue, Feb 21, 2017 at 5:34 PM Gerd Hoffmann <address@hidden> wrote:

> Reported by Coverity: CID 1371242, 1371243, 1371244.
>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Peter Maydell <address@hidden>
> Cc: Daniel P. Berrange <address@hidden>
> Signed-off-by: Gerd Hoffmann <address@hidden>
>


Reviewed-by: Marc-André Lureau <address@hidden>


---
>  ui/vnc.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 62e85ed..51f4b30 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3181,6 +3181,7 @@ static void vnc_display_close(VncDisplay *vd)
>      g_free(vd->lsock);
>      g_free(vd->lsock_tag);
>      vd->lsock = NULL;
> +    vd->lsock_tag = NULL;
>      vd->nlsock = 0;
>
>      for (i = 0; i < vd->nlwebsock; i++) {
> @@ -3192,6 +3193,7 @@ static void vnc_display_close(VncDisplay *vd)
>      g_free(vd->lwebsock);
>      g_free(vd->lwebsock_tag);
>      vd->lwebsock = NULL;
> +    vd->lwebsock_tag = NULL;
>      vd->nlwebsock = 0;
>
>      vd->auth = VNC_AUTH_INVALID;
> @@ -3204,6 +3206,7 @@ static void vnc_display_close(VncDisplay *vd)
>      vd->tlsaclname = NULL;
>      if (vd->lock_key_sync) {
>          qemu_remove_led_event_handler(vd->led);
> +        vd->led = NULL;
>      }
>  }
>
> --
> 1.8.3.1
>
>
> --
Marc-André Lureau