Re: [Qemu-devel] [PATCH v5 17/18] block: remove all encryption handling APIs

[Alberto Garcia]

On Tue 21 Feb 2017 12:55:11 PM CET, Daniel P. Berrange wrote:
> @@ -2244,24 +2240,8 @@ void qmp_block_passwd(bool has_device, const char 
> *device,
>                        bool has_node_name, const char *node_name,
>                        const char *password, Error **errp)
>  {
> -    Error *local_err = NULL;
> -    BlockDriverState *bs;
> -    AioContext *aio_context;
> -
> -    bs = bdrv_lookup_bs(has_device ? device : NULL,
> -                        has_node_name ? node_name : NULL,
> -                        &local_err);
> -    if (local_err) {
> -        error_propagate(errp, local_err);
> -        return;
> -    }
> -
> -    aio_context = bdrv_get_aio_context(bs);
> -    aio_context_acquire(aio_context);
> -
> -    bdrv_add_key(bs, password, errp);
> -
> -    aio_context_release(aio_context);
> +    error_setg(errp,
> +               "Setting block passwords directly is no longer supported");
>  }

Shouldn't you also update the command description in block-core.json and
hmp-commands.hx ?

Berto