qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 09/14] tests: Don't check qobject_type() before


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 09/14] tests: Don't check qobject_type() before qobject_to_qstring()
Date: Tue, 21 Feb 2017 11:50:58 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0

On 02/17/2017 02:38 PM, Markus Armbruster wrote:
> qobject_to_qstring(obj) returns NULL when obj isn't a QString.  Check
> that instead of qobject_type(obj) == QTYPE_QSTRING.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  tests/check-qjson.c                 | 31 ++++++++-----------------------
>  tests/test-qobject-output-visitor.c | 37 
> +++++++++++++++++--------------------
>  2 files changed, 25 insertions(+), 43 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]