Re: [Qemu-devel] [PATCH 01/12] s390x/s390-virtio: get rid of DPRINTF

[Philippe Mathieu-Daudé]

On 02/20/2017 06:57 AM, Cornelia Huck wrote:
> The DPRINTF approach is likely to introduce bitrot, and the preferred
> way for debugging is tracing anyway. Fortunately, there are no users
> (left), so nuke it.
>
> Signed-off-by: Cornelia Huck <address@hidden>
> Reviewed-by: Halil Pasic <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  hw/s390x/s390-virtio.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/hw/s390x/s390-virtio.c b/hw/s390x/s390-virtio.c
> index 7a3a7fe5fd..9cfb09057e 100644
> --- a/hw/s390x/s390-virtio.c
> +++ b/hw/s390x/s390-virtio.c
> @@ -44,16 +44,6 @@
>  #include "hw/s390x/ipl.h"
>  #include "cpu.h"
>
> -//#define DEBUG_S390
> -
> -#ifdef DEBUG_S390
> -#define DPRINTF(fmt, ...) \
> -    do { fprintf(stderr, fmt, ## __VA_ARGS__); } while (0)
> -#else
> -#define DPRINTF(fmt, ...) \
> -    do { } while (0)
> -#endif
> -
>  #define MAX_BLK_DEVS                    10
>
>  #define S390_TOD_CLOCK_VALUE_MISSING    0x00