Re: [Qemu-devel] [PATCH v2 0/3] simplify struct QOM properties and use the result for GUEST_PANICKED

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v2 0/3] simplify struct QOM properties and use the 
result for GUEST_PANICKED
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
3c23639 vl: pass CPUState to qemu_system_guest_panicked
e22eb3a cpu: implement get_crash_info through QOM properties
a359a36 qom-qobject: introduce object_property_{g, s}et_ptr

=== OUTPUT BEGIN ===
Checking PATCH 1/3: qom-qobject: introduce object_property_{g, s}et_ptr...
WARNING: line over 80 characters
#427: FILE: tests/check-qom-proplist.c:702:
+    g_test_add_func("/qom/proplist/get-set-ptr/struct", 
test_dummy_get_set_ptr_struct);

WARNING: line over 80 characters
#428: FILE: tests/check-qom-proplist.c:703:
+    g_test_add_func("/qom/proplist/get-set-ptr/error", 
test_dummy_get_set_ptr_error);

ERROR: line over 90 characters
#429: FILE: tests/check-qom-proplist.c:704:
+    g_test_add_func("/qom/proplist/get-set-ptr/covariant", 
test_dummy_get_set_ptr_covariant);

ERROR: line over 90 characters
#430: FILE: tests/check-qom-proplist.c:705:
+    g_test_add_func("/qom/proplist/get-set-ptr/contravariant", 
test_dummy_get_set_ptr_contravariant);

total: 2 errors, 2 warnings, 419 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/3: cpu: implement get_crash_info through QOM properties...
Checking PATCH 3/3: vl: pass CPUState to qemu_system_guest_panicked...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden