[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] Changing error message of QMP 'migrate_set_d
|
From: |
Juan Quintela |
|
Subject: |
Re: [Qemu-devel] [PATCH v3] Changing error message of QMP 'migrate_set_downtime' to seconds |
|
Date: |
Wed, 22 Feb 2017 20:40:41 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Daniel Henrique Barboza <address@hidden> wrote:
> Using QMP, the error message of 'migrate_set_downtime' was displaying
> the values in milliseconds, being misleading with the command that
> accepts the value in seconds:
>
> { "execute": "migrate_set_downtime", "arguments": {"value": 3000}}
> {"error": {"class": "GenericError", "desc": "Parameter 'downtime_limit'
> expects an integer in the range of 0 to 2000000 milliseconds"}}
>
> This message is also seen in HMP when trying to set the same
> parameter:
>
> (qemu) migrate_set_parameter downtime-limit 3000000
> Parameter 'downtime_limit' expects an integer in the range of 0 to
> 2000000 milliseconds
>
> To allow for a proper error message when using QMP, a validation
> of the user input was added in 'qmp_migrate_set_downtime'.
>
> Signed-off-by: Daniel Henrique Barboza <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Queued. Thanks.