Re: [Qemu-devel] [PATCH v2 3/3] bcm2835: add sdhost and gpio controllers

[Andrew Baumann]

Hi,

> From: Clement Deschamps [mailto:address@hidden
> Sent: Wednesday, 22 February 2017 3:24
> Subject: [PATCH v2 3/3] bcm2835: add sdhost and gpio controllers
> 
> This adds the bcm2835_sdhost and bcm2835_gpio to the BCM2835 platform.
> 
> The bcm2835_gpio has a link to both the sdhci and sdhost controllers for
> supporting the alternate function of GPIOs 48-53 (SD controller selection)
> 
> Signed-off-by: Clement Deschamps <address@hidden>
[...]
> +    /* SDHOST */
> +    object_property_set_bool(OBJECT(&s->sdhost), true, "realized", &err);
> +    if (err) {
> +        error_propagate(errp, err);
> +        return;
> +    }
> +
> +    memory_region_add_subregion(&s->peri_mr, MMCI0_OFFSET,
> +                sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->sdhost), 0));
> +    sysbus_connect_irq(SYS_BUS_DEVICE(&s->sdhost), 0,
> +        qdev_get_gpio_in_named(DEVICE(&s->ic), BCM2835_IC_GPU_IRQ,
> +                               INTERRUPT_SDIO));
> +    object_property_add_alias(OBJECT(s), "sd-bus-2", OBJECT(&s->sdhost),
> +                              "sd-bus", &err);

Is this alias still meaningful / needed, or is it a relic from the previous 
version? Right now it doesn't appear to be used, and I'm thinking that if 
someone did try to use it (e.g. at the board level by connecting an SD card) 
then the new GPIO logic would allow swapping the two SD cards between the two 
controllers, which doesn't sound like a faithful recreation of the hardware.

Otherwise,
Reviewed-by: Andrew Baumann <address@hidden>

Cheers,
Andrew